chore: fixing eslint configuration #630
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
force-pushed
the
fix/eslint
branch
5 times, most recently
from
98046cd to
5731708
Compare
Comment on lines
+39
to
+41
| - name: Setup | ||
| # The Tailwind Prettier plugin requires the Tailwind preset to be built, as the plugin depends on the configuration provided by the preset for linting to function correctly. | ||
| run: yarn workspace @metamask/design-system-tailwind-preset build |
There was a problem hiding this comment.
This update to our linting step is required for ensuring that the Tailwind Prettier plugin operates correctly. By running yarn workspace @metamask/design-system-tailwind-preset build, we ensure that the Tailwind preset is built and its configuration is available. Without this step, the Tailwind Prettier plugin would fail to lint properly since it relies on the preset's configuration to validate styles accurately.
Without this update our CI will fail at the linting step. yarn lint will also fail locally if the tailwind preset is not built.
georgewrmarshall
force-pushed
the
fix/eslint
branch
from
30cf765 to
06e1598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TBC but TLDR is fixing eslint configuration to catch missing linting errors and align with core
Related issues
Fixes: #629
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist